docs: align historical plans/specs with renamed identifiers (roundTrip -> execute, log schema)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -165,14 +165,14 @@ EOF
|
||||
### Task 2: `internal/garmin/client.go` exposes `ErrNotFound`
|
||||
|
||||
**Files:**
|
||||
- Modify: `backend/internal/garmin/client.go` (`wireResponse`, new `ErrNotFound`, `roundTrip`)
|
||||
- Modify: `backend/internal/garmin/client.go` (`wireResponse`, new `ErrNotFound`, `execute`)
|
||||
- Modify: `backend/internal/garmin/client_test.go` (`wireResponsePayload`/harness, new test)
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: `wireResponse.NotFound` (wire field written by Task 1's `wrapper.py` change).
|
||||
- Produces: `var ErrNotFound error` -- Task 4 (`fillPendingWorkouts`) checks
|
||||
`errors.Is(err, garmin.ErrNotFound)` against errors returned by `GetWorkoutByID` (and, since
|
||||
this is wired at the generic `roundTrip` level, any other `Client` method too).
|
||||
this is wired at the generic `execute` level, any other `Client` method too).
|
||||
|
||||
- [ ] **Step 1: Write the failing test**
|
||||
|
||||
@@ -256,7 +256,7 @@ already added it to the test file; the actual compile failure is `wireResponse`
|
||||
`NotFound` yet, and `ErrNotFound` is undefined) -- confirms the test exercises code that doesn't
|
||||
exist yet.
|
||||
|
||||
- [ ] **Step 3: Add `ErrNotFound` and wire it through `roundTrip`**
|
||||
- [ ] **Step 3: Add `ErrNotFound` and wire it through `execute`**
|
||||
|
||||
In `backend/internal/garmin/client.go`, replace:
|
||||
|
||||
@@ -289,7 +289,7 @@ type wireResponse struct {
|
||||
var ErrNotFound = errors.New("garmin: resource not found")
|
||||
```
|
||||
|
||||
Replace, in `roundTrip`:
|
||||
Replace, in `execute`:
|
||||
|
||||
```go
|
||||
if resp.Error != "" {
|
||||
|
||||
Reference in New Issue
Block a user