kriss/geniusrun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: restore standard HR zone defaults, relax zone-boundary validation instead of migration

Browse Source
This commit is contained in:
Kriss Vila
2026-07-17 19:06:01 +02:00
parent 57be9065cd
commit 9c42931c9e
3 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/internal/api/profile.go
View File

@@ -19,12 +19,6 @@ func validateProfile(p store.Profile) error {
{p.HRZone4MinPct, p.HRZone4MaxPct}, {p.HRZone4MinPct, p.HRZone4MaxPct},
{p.HRZone5MinPct, p.HRZone5MaxPct}, {p.HRZone5MinPct, p.HRZone5MaxPct},
} }
if zones[0][0] != 0 {
return errors.New("zone 1 must start at 0%")
}
if zones[len(zones)-1][1] != 100 {
return errors.New("zone 5 must end at 100%")
}
for i, z := range zones { for i, z := range zones {
if z[0] >= z[1] { if z[0] >= z[1] {
return errors.New("each HR zone's min must be less than its max") return errors.New("each HR zone's min must be less than its max")

18
backend/internal/store/migrations/0003_profile.sql
View File

@@ -7,15 +7,15 @@ CREATE TABLE profile (
rolling_window_days INTEGER NOT NULL DEFAULT 90, rolling_window_days INTEGER NOT NULL DEFAULT 90,
max_heart_rate REAL, max_heart_rate REAL,
resting_heart_rate REAL, resting_heart_rate REAL,
hr_zone1_min_pct REAL NOT NULL DEFAULT 0, hr_zone1_min_pct REAL NOT NULL DEFAULT 50,
hr_zone1_max_pct REAL NOT NULL DEFAULT 20, hr_zone1_max_pct REAL NOT NULL DEFAULT 60,
hr_zone2_min_pct REAL NOT NULL DEFAULT 20, hr_zone2_min_pct REAL NOT NULL DEFAULT 60,
hr_zone2_max_pct REAL NOT NULL DEFAULT 40, hr_zone2_max_pct REAL NOT NULL DEFAULT 70,
hr_zone3_min_pct REAL NOT NULL DEFAULT 40, hr_zone3_min_pct REAL NOT NULL DEFAULT 70,
hr_zone3_max_pct REAL NOT NULL DEFAULT 60, hr_zone3_max_pct REAL NOT NULL DEFAULT 80,
hr_zone4_min_pct REAL NOT NULL DEFAULT 60, hr_zone4_min_pct REAL NOT NULL DEFAULT 80,
hr_zone4_max_pct REAL NOT NULL DEFAULT 80, hr_zone4_max_pct REAL NOT NULL DEFAULT 90,
hr_zone5_min_pct REAL NOT NULL DEFAULT 80, hr_zone5_min_pct REAL NOT NULL DEFAULT 90,
hr_zone5_max_pct REAL NOT NULL DEFAULT 100, hr_zone5_max_pct REAL NOT NULL DEFAULT 100,
easy_warmup_minutes REAL NOT NULL DEFAULT 10, easy_warmup_minutes REAL NOT NULL DEFAULT 10,
easy_cooldown_minutes REAL NOT NULL DEFAULT 5, easy_cooldown_minutes REAL NOT NULL DEFAULT 5,

4
backend/internal/store/profile_test.go
View File

@@ -16,8 +16,8 @@ func TestProfile_DefaultsThenUpdate(t *testing.T) {
if p.RollingWindowDays != 90 { if p.RollingWindowDays != 90 {
t.Errorf("RollingWindowDays = %d, want 90 (migration default)", p.RollingWindowDays) t.Errorf("RollingWindowDays = %d, want 90 (migration default)", p.RollingWindowDays)
} }
if p.HRZone1MinPct != 0 || p.HRZone5MaxPct != 100 { if p.HRZone1MinPct != 50 || p.HRZone5MaxPct != 100 {
t.Errorf("zone defaults = %+v, want Z1 min=0, Z5 max=100", p) t.Errorf("zone defaults = %+v, want Z1 min=50, Z5 max=100", p)
} }
maxHR, restingHR := 190.0, 50.0 maxHR, restingHR := 190.0, 50.0