kriss/geniusrun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: classification reads max HR from the profile instead of static config

Browse Source 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Kriss Vila
2026-07-17 19:13:24 +02:00
parent 078c87c413
commit c11dd152ba
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
backend/internal/sync/service.go
View File

@@ -35,8 +35,6 @@ type Config struct {
// MinConfidence is the classify.Classify threshold below which even a // MinConfidence is the classify.Classify threshold below which even a
// single matching kind is sent to manual review. // single matching kind is sent to manual review.
MinConfidence float64 MinConfidence float64
// MaxHR is used only to derive avg_hr_pct_max for the rule engine.
MaxHR float64
} }
func (c Config) withDefaults() Config { func (c Config) withDefaults() Config {
@@ -296,8 +294,16 @@ func (s *Service) ClassifyActivity(ctx context.Context, activityID int64) error
if err != nil { if err != nil {
return fmt.Errorf("parse workout kind rules: %w", err) return fmt.Errorf("parse workout kind rules: %w", err)
} }
profile, err := s.db.GetProfile(ctx)
if err != nil {
return fmt.Errorf("load profile: %w", err)
}
var maxHR float64
if profile.MaxHeartRate != nil {
maxHR = *profile.MaxHeartRate
}
ctxMetrics := buildMetricContext(activity, laps, s.cfg.MaxHR) ctxMetrics := buildMetricContext(activity, laps, maxHR)
result := classify.Classify(ctxMetrics, rules, s.cfg.MinConfidence) result := classify.Classify(ctxMetrics, rules, s.cfg.MinConfidence)
candidatesJSON, err := json.Marshal(result.Candidates) candidatesJSON, err := json.Marshal(result.Candidates)

2
backend/internal/sync/service_test.go
View File

@@ -87,7 +87,7 @@ func TestFillPendingDetailsAndClassify_EndToEnd(t *testing.T) {
}, },
}, },
} }
svc := NewService(m, db, Config{MinConfidence: 0.5, MaxHR: 190}, fixedNow(time.Date(2026, 7, 11, 0, 0, 0, 0, time.UTC))) svc := NewService(m, db, Config{MinConfidence: 0.5}, fixedNow(time.Date(2026, 7, 11, 0, 0, 0, 0, time.UTC)))
if err := svc.Backfill(ctx); err != nil { if err := svc.Backfill(ctx); err != nil {
t.Fatalf("Backfill: %v", err) t.Fatalf("Backfill: %v", err)