refactor: merge internal/sync into internal/garmin, regroup api files and routes
Garmin auth/sync routes move under /api/garmin/*; sync.Service becomes garmin.Sync with garmin.SyncConfig/ClientConfig; applog becomes internal/log; the test mock moves into the garmin package as MockClient (breaking the test-only import cycle the merge created); stale test URLs and type names updated to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
233
backend/internal/garmin/wrapper/wrapper.py
Normal file
233
backend/internal/garmin/wrapper/wrapper.py
Normal file
@@ -0,0 +1,233 @@
|
||||
"""Subprocess wrapper around garminconnect, spoken to over newline-delimited
|
||||
JSON on stdin/stdout by geniusrund's internal/garmin package. See
|
||||
docs/superpowers/specs/2026-07-25-garmin-direct-wrapper-design.md."""
|
||||
|
||||
import json
|
||||
import os
|
||||
import queue
|
||||
import sys
|
||||
import threading
|
||||
import traceback
|
||||
|
||||
from garminconnect import Garmin, GarminConnectNotFoundError
|
||||
|
||||
TOKENSTORE = os.path.expanduser(os.environ.get("GARMIN_TOKENSTORE", "~/.garmin"))
|
||||
|
||||
_client = None
|
||||
_auth_state = "unauthenticated"
|
||||
_mfa_input_queue = queue.Queue()
|
||||
_login_result_queue = queue.Queue()
|
||||
# Set the first time this subprocess attempts any login, whichever path
|
||||
# gets there first (see _handle_call's lazy call and _handle_authenticate) --
|
||||
# guarantees _startup_login runs at most once per subprocess lifetime, and
|
||||
# never at all once an explicit authenticate has been attempted.
|
||||
_startup_login_attempted = False
|
||||
|
||||
|
||||
def _debug(msg):
|
||||
print(f"[garmin-wrapper debug] {msg}", file=sys.stderr, flush=True)
|
||||
|
||||
|
||||
def _prompt_mfa():
|
||||
_debug("garminconnect invoked prompt_mfa() -- this is a REAL MFA challenge from Garmin")
|
||||
code = _mfa_input_queue.get(timeout=300)
|
||||
_debug(f"prompt_mfa() handing code of length {len(code)} back to garminconnect")
|
||||
return code
|
||||
|
||||
|
||||
def _startup_login():
|
||||
"""Silently resume a cached tokenstore session, so a freshly
|
||||
(re)spawned subprocess can already be authenticated for a data 'call'
|
||||
that never goes through the explicit authenticate command -- e.g.
|
||||
"Sync now" reaching an already-connected user's client right after a
|
||||
backend restart cleared the in-memory cache.
|
||||
|
||||
Called lazily (see _handle_call), at most once per subprocess lifetime,
|
||||
and only if nothing has explicitly called authenticate first. Running
|
||||
it unconditionally at process start used to be actively counterproductive
|
||||
whenever the very first command actually was authenticate: on success it
|
||||
just duplicated a login _handle_authenticate was about to redo anyway
|
||||
(it always rebuilds _client from scratch), and on failure it was a
|
||||
wasted, unauthenticated hit against Garmin's servers moments before the
|
||||
real attempt -- extra load that only makes rate-limiting worse.
|
||||
|
||||
Bounded to the same 10s timeout as _handle_authenticate: the actual
|
||||
login runs on a background daemon thread, and this function waits up
|
||||
to 10s for it before returning either way, so a slow/rate-limited
|
||||
Garmin login can never block the caller indefinitely -- if it times
|
||||
out, the thread keeps running and will update _auth_state whenever it
|
||||
eventually finishes (success or failure), just without wedging the
|
||||
whole subprocess unresponsive in the meantime.
|
||||
|
||||
Deliberately uses its own private, function-local result queue rather
|
||||
than the module-level _login_result_queue that _handle_authenticate and
|
||||
_handle_complete_mfa share -- those two are legitimately two halves of
|
||||
one explicit, MFA-capable login flow and must share a queue for the MFA
|
||||
handoff to work, but this is a plain background tokenstore resume with
|
||||
no MFA involved. Sharing the queue here would let this thread's stale
|
||||
result (arriving after the 10s timeout below) be dequeued by an
|
||||
unrelated, later authenticate/complete_mfa call instead of that call's
|
||||
own fresh result."""
|
||||
global _client, _auth_state
|
||||
email = os.environ.get("GARMIN_EMAIL")
|
||||
password = os.environ.get("GARMIN_PASSWORD")
|
||||
if not email or not password:
|
||||
return
|
||||
|
||||
_client = Garmin(email, password)
|
||||
result_queue = queue.Queue() # private to this call, never shared with authenticate/complete_mfa
|
||||
|
||||
def _do_login():
|
||||
try:
|
||||
_client.login(tokenstore=TOKENSTORE)
|
||||
result_queue.put(("success", None))
|
||||
except Exception as exc:
|
||||
result_queue.put(("error", str(exc)))
|
||||
|
||||
threading.Thread(target=_do_login, daemon=True).start()
|
||||
|
||||
try:
|
||||
status, err = result_queue.get(timeout=10)
|
||||
if status == "success":
|
||||
_auth_state = "authenticated"
|
||||
else:
|
||||
_debug(f"startup tokenstore login failed: {err}")
|
||||
_auth_state = "unauthenticated"
|
||||
except queue.Empty:
|
||||
_debug(
|
||||
"startup tokenstore login hit the 10s timeout -- still running in the "
|
||||
"background and will update auth state whenever it finishes"
|
||||
)
|
||||
_auth_state = "unauthenticated"
|
||||
|
||||
|
||||
def _handle_authenticate(_params):
|
||||
global _client, _auth_state, _startup_login_attempted
|
||||
# An explicit authenticate is happening (successful or not) -- the lazy
|
||||
# startup-login fallback in _handle_call must never fire after this, it
|
||||
# would be redundant at best and a wasted extra hit against Garmin at
|
||||
# worst.
|
||||
_startup_login_attempted = True
|
||||
|
||||
email = os.environ.get("GARMIN_EMAIL", "")
|
||||
password = os.environ.get("GARMIN_PASSWORD", "")
|
||||
if not email or not password:
|
||||
return {
|
||||
"status": "failed",
|
||||
"message": "GARMIN_EMAIL and GARMIN_PASSWORD environment variables are required.",
|
||||
}
|
||||
|
||||
def _do_login():
|
||||
_debug(f"background login thread starting _client.login(tokenstore={TOKENSTORE})")
|
||||
try:
|
||||
_client.login(tokenstore=TOKENSTORE)
|
||||
_debug("_client.login() returned successfully")
|
||||
_login_result_queue.put(("success", None))
|
||||
except Exception as exc:
|
||||
_debug(f"_client.login() raised {type(exc).__name__}: {exc}")
|
||||
_debug(traceback.format_exc())
|
||||
_login_result_queue.put(("error", str(exc)))
|
||||
|
||||
_client = Garmin(email, password)
|
||||
_client.prompt_mfa = _prompt_mfa
|
||||
threading.Thread(target=_do_login, daemon=True).start()
|
||||
|
||||
try:
|
||||
status, err = _login_result_queue.get(timeout=10)
|
||||
_debug(f"authenticate got result within 10s timeout: status={status}")
|
||||
if status == "success":
|
||||
_auth_state = "authenticated"
|
||||
return {"status": "success", "message": "Authenticated successfully."}
|
||||
return {"status": "failed", "message": f"Authentication failed: {err}"}
|
||||
except queue.Empty:
|
||||
_debug(
|
||||
"authenticate hit the 10s timeout with no result yet -- reporting mfa_required, "
|
||||
"but this does NOT necessarily mean prompt_mfa() was actually invoked; check "
|
||||
"whether the 'REAL MFA challenge' debug line above appears to tell real MFA "
|
||||
"apart from a merely slow login."
|
||||
)
|
||||
_auth_state = "mfa_pending"
|
||||
return {
|
||||
"status": "mfa_required",
|
||||
"message": "MFA required. Garmin has sent a verification code to your registered email or phone.",
|
||||
}
|
||||
|
||||
|
||||
def _handle_complete_mfa(params):
|
||||
global _auth_state
|
||||
|
||||
if _auth_state != "mfa_pending":
|
||||
return {"status": "failed", "message": "No MFA in progress. Call authenticate first."}
|
||||
|
||||
code = params["code"]
|
||||
_debug(f"complete_mfa received a code of length {len(code)}, pushing to mfa queue")
|
||||
_mfa_input_queue.put(code)
|
||||
|
||||
try:
|
||||
status, err = _login_result_queue.get(timeout=30)
|
||||
_debug(f"complete_mfa got result: status={status} err={err}")
|
||||
if status == "success":
|
||||
_auth_state = "authenticated"
|
||||
return {"status": "success", "message": "MFA accepted. Authenticated successfully."}
|
||||
return {"status": "failed", "message": f"Authentication failed after MFA: {err}"}
|
||||
except queue.Empty:
|
||||
_auth_state = "unauthenticated"
|
||||
return {
|
||||
"status": "failed",
|
||||
"message": "Timed out waiting for authentication to complete. Call authenticate again.",
|
||||
}
|
||||
|
||||
|
||||
def _handle_call(params):
|
||||
global _startup_login_attempted
|
||||
if _auth_state != "authenticated" and not _startup_login_attempted:
|
||||
_startup_login_attempted = True
|
||||
_startup_login()
|
||||
if _auth_state != "authenticated":
|
||||
raise RuntimeError("Not authenticated. Call authenticate first.")
|
||||
method = params["method"]
|
||||
args = params.get("args") or {}
|
||||
fn = getattr(_client, method)
|
||||
return fn(**args)
|
||||
|
||||
|
||||
_HANDLERS = {
|
||||
"authenticate": _handle_authenticate,
|
||||
"complete_mfa": _handle_complete_mfa,
|
||||
"call": _handle_call,
|
||||
}
|
||||
|
||||
|
||||
def dispatch(req):
|
||||
handler = _HANDLERS.get(req.get("cmd"))
|
||||
if handler is None:
|
||||
return {"id": req.get("id"), "error": f"unknown cmd {req.get('cmd')!r}"}
|
||||
try:
|
||||
result = handler(req.get("params") or {})
|
||||
return {"id": req["id"], "result": result}
|
||||
except Exception as exc:
|
||||
_debug(f"{req.get('cmd')} raised {type(exc).__name__}: {exc}")
|
||||
_debug(traceback.format_exc())
|
||||
resp = {"id": req.get("id"), "error": str(exc)}
|
||||
# A 404 (e.g. get_workout_by_id for a workout deleted on Garmin's
|
||||
# side after being linked to an activity) is definitive, not a
|
||||
# transient failure worth retrying forever -- marked specifically so
|
||||
# internal/garmin/client.go can tell the two apart (see
|
||||
# docs/superpowers/specs/2026-07-27-workout-not-found-design.md).
|
||||
if isinstance(exc, GarminConnectNotFoundError):
|
||||
resp["not_found"] = True
|
||||
return resp
|
||||
|
||||
|
||||
def main():
|
||||
for line in sys.stdin:
|
||||
line = line.strip()
|
||||
if not line:
|
||||
continue
|
||||
req = json.loads(line)
|
||||
resp = dispatch(req)
|
||||
print(json.dumps(resp), flush=True)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
Reference in New Issue
Block a user