geniusrun/backend/internal/store/store_test.go

package store

import (
	"context"
	"path/filepath"
	"strings"
	"testing"
)

func openTestDB(t *testing.T) *DB {
	t.Helper()
	path := filepath.Join(t.TempDir(), "geniusrun_test.db")
	db, err := Open(path)
	if err != nil {
		t.Fatalf("Open: %v", err)
	}
	t.Cleanup(func() { db.Close() })
	return db
}

func f(v float64) *float64 { return &v }

func TestMigrateIsIdempotent(t *testing.T) {
	path := filepath.Join(t.TempDir(), "geniusrun_test.db")
	db1, err := Open(path)
	if err != nil {
		t.Fatalf("first Open: %v", err)
	}
	db1.Close()

	db2, err := Open(path)
	if err != nil {
		t.Fatalf("second Open (re-applying migrations): %v", err)
	}
	db2.Close()
}

func TestUpsertActivity_InsertThenUpdateIsIdempotent(t *testing.T) {
	db := openTestDB(t)
	ctx := context.Background()

	a := Activity{
		GarminActivityID: 23554066504,
		StartTimeUTC:     "2026-07-11 05:02:35",
		DurationSeconds:  1800,
		DistanceMeters:   6858,
		AvgHR:            f(148),
		RawJSON:          `{"activityId":23554066504,"activityName":"Auriol - W2-5-Base Endurance","activityType":{"typeKey":"running"}}`,
	}

	id, err := db.UpsertActivity(ctx, a)
	if err != nil {
		t.Fatalf("UpsertActivity (insert): %v", err)
	}

	a.AvgHR = f(150) // simulate a re-sync with a corrected value
	id2, err := db.UpsertActivity(ctx, a)
	if err != nil {
		t.Fatalf("UpsertActivity (update): %v", err)
	}
	if id != id2 {
		t.Fatalf("expected same internal id across upserts, got %d then %d", id, id2)
	}

	got, ok, err := db.GetActivity(ctx, id)
	if err != nil || !ok {
		t.Fatalf("GetActivity: ok=%v err=%v", ok, err)
	}
	if *got.AvgHR != 150 {
		t.Errorf("AvgHR = %v, want 150 (update should have applied)", *got.AvgHR)
	}

	all, err := db.ListActivities(ctx, ActivityFilter{})
	if err != nil {
		t.Fatalf("ListActivities: %v", err)
	}
	if len(all) != 1 {
		t.Fatalf("expected exactly 1 activity after upsert-update, got %d", len(all))
	}
}

func TestKindAssignment_AppendOnlyHistoryAndCurrentView(t *testing.T) {
	db := openTestDB(t)
	ctx := context.Background()

	activityID, err := db.UpsertActivity(ctx, Activity{
		GarminActivityID: 1,
		StartTimeUTC:     "2026-07-11 05:00:00",
		RawJSON:          "{}",
	})
	if err != nil {
		t.Fatalf("UpsertActivity: %v", err)
	}

	kindID, err := db.CreateWorkoutKind(ctx, WorkoutKind{
		Name:     "Test Assignment Custom",
		RuleJSON: `{"match":"all","conditions":[]}`,
		IsActive: true,
	})
	if err != nil {
		t.Fatalf("CreateWorkoutKind: %v", err)
	}

	// First: rule engine says needs_review (ambiguous).
	if _, err := db.InsertKindAssignment(ctx, KindAssignment{
		ActivityID:         activityID,
		AssignmentSource:   AssignmentSourceRuleEngine,
		Status:             AssignmentStatusNeedsReview,
		CandidateKindsJSON: `[{"kind_id":1,"score":0.5}]`,
	}); err != nil {
		t.Fatalf("InsertKindAssignment (rule engine): %v", err)
	}

	queue, err := db.ReviewQueue(ctx)
	if err != nil {
		t.Fatalf("ReviewQueue: %v", err)
	}
	if len(queue) != 1 {
		t.Fatalf("expected 1 item in review queue, got %d", len(queue))
	}

	// Then: user manually resolves it.
	if _, err := db.InsertKindAssignment(ctx, KindAssignment{
		ActivityID:       activityID,
		WorkoutKindID:    &kindID,
		AssignmentSource: AssignmentSourceManual,
		Status:           AssignmentStatusAssigned,
	}); err != nil {
		t.Fatalf("InsertKindAssignment (manual): %v", err)
	}

	queue, err = db.ReviewQueue(ctx)
	if err != nil {
		t.Fatalf("ReviewQueue after resolve: %v", err)
	}
	if len(queue) != 0 {
		t.Fatalf("expected 0 items in review queue after manual resolve, got %d", len(queue))
	}

	current, ok, err := db.CurrentAssignment(ctx, activityID)
	if err != nil || !ok {
		t.Fatalf("CurrentAssignment: ok=%v err=%v", ok, err)
	}
	if current.AssignmentSource != AssignmentSourceManual || current.Status != AssignmentStatusAssigned {
		t.Errorf("current assignment = %+v, want manual/assigned", current)
	}

	// The original rule-engine assignment must still exist (append-only history).
	var historyCount int
	if err := db.QueryRowContext(ctx, `SELECT COUNT(*) FROM kind_assignments WHERE activity_id = ?`, activityID).Scan(&historyCount); err != nil {
		t.Fatalf("count history: %v", err)
	}
	if historyCount != 2 {
		t.Errorf("expected 2 historical assignment rows (rule engine + manual), got %d", historyCount)
	}

	forKind, err := db.AssignmentsForKind(ctx, kindID)
	if err != nil {
		t.Fatalf("AssignmentsForKind: %v", err)
	}
	if len(forKind) != 1 {
		t.Fatalf("expected 1 assigned activity for kind %d, got %d", kindID, len(forKind))
	}
}

func TestReplaceLapsIsIdempotent(t *testing.T) {
	db := openTestDB(t)
	ctx := context.Background()

	activityID, err := db.UpsertActivity(ctx, Activity{
		GarminActivityID: 2,
		StartTimeUTC:     "2026-07-11 05:00:00",
		RawJSON:          "{}",
	})
	if err != nil {
		t.Fatalf("UpsertActivity: %v", err)
	}

	laps := []Lap{
		{LapIndex: 1, RawJSON: "{}"},
		{LapIndex: 2, RawJSON: "{}"},
	}
	if err := db.ReplaceLaps(ctx, activityID, laps); err != nil {
		t.Fatalf("ReplaceLaps (first): %v", err)
	}
	// Re-sync with a different set (e.g. corrected data) should fully replace, not append.
	if err := db.ReplaceLaps(ctx, activityID, laps[:1]); err != nil {
		t.Fatalf("ReplaceLaps (second): %v", err)
	}

	got, err := db.LapsForActivity(ctx, activityID)
	if err != nil {
		t.Fatalf("LapsForActivity: %v", err)
	}
	if len(got) != 1 {
		t.Fatalf("expected 1 lap after replace, got %d", len(got))
	}
}

func TestUsersAndOwnershipSchema_AppliesCleanly(t *testing.T) {
	db := openTestDB(t)
	ctx := context.Background()

	// A fresh DB has no legacy singleton rows, so every user_id column
	// should already be backfilled to nothing (fresh install, no rows at
	// all yet in these tables besides the migration-seeded workout_kinds --
	// which do have NULL user_id until a real user is provisioned).
	var nullableCount int
	if err := db.QueryRowContext(ctx, `SELECT COUNT(*) FROM workout_kinds WHERE user_id IS NULL`).Scan(&nullableCount); err != nil {
		t.Fatalf("count workout_kinds: %v", err)
	}
	if nullableCount != 8 {
		t.Fatalf("expected 8 migration-seeded workout_kinds with NULL user_id on a fresh DB, got %d", nullableCount)
	}

	// UNIQUE(user_id, name) allows the same name across two different users.
	if _, err := db.ExecContext(ctx, `INSERT INTO users (oidc_sub, display_name) VALUES ('sub-a', 'A'), ('sub-b', 'B')`); err != nil {
		t.Fatalf("insert users: %v", err)
	}
	if _, err := db.ExecContext(ctx, `
		INSERT INTO workout_kinds (user_id, name, rule_json)
		VALUES ((SELECT id FROM users WHERE oidc_sub='sub-a'), 'Custom Kind', '{}'),
		       ((SELECT id FROM users WHERE oidc_sub='sub-b'), 'Custom Kind', '{}')`); err != nil {
		t.Fatalf("expected same workout_kind name to be allowed across two different users, got: %v", err)
	}

	// profile/sync_state UNIQUE(user_id) still rejects a genuine duplicate.
	if _, err := db.ExecContext(ctx, `INSERT INTO profile (user_id) VALUES ((SELECT id FROM users WHERE oidc_sub='sub-a'))`); err != nil {
		t.Fatalf("insert profile for sub-a: %v", err)
	}
	if _, err := db.ExecContext(ctx, `INSERT INTO profile (user_id) VALUES ((SELECT id FROM users WHERE oidc_sub='sub-a'))`); err == nil {
		t.Fatal("expected a second profile row for the same user_id to violate UNIQUE(user_id)")
	}
}

func TestForeignKeyEnforcementPostMigration(t *testing.T) {
	db := openTestDB(t)
	ctx := context.Background()

	// Verify that FK enforcement is correctly active after migrations complete.
	// This tests that the PRAGMA foreign_keys toggle in db.migrate() (for
	// migrations 0023/0024/0025) is properly scoped and re-enabled after each
	// table rebuild.

	// Insert an activity that we can reference.
	activityID, err := db.UpsertActivity(ctx, Activity{
		GarminActivityID: 1001,
		StartTimeUTC:     "2026-07-11 05:00:00",
		RawJSON:          "{}",
	})
	if err != nil {
		t.Fatalf("UpsertActivity: %v", err)
	}

	// Get the ID of one of the 8 migration-seeded workout_kinds.
	var seedKindID int64
	if err := db.QueryRowContext(ctx, `SELECT id FROM workout_kinds LIMIT 1`).Scan(&seedKindID); err != nil {
		t.Fatalf("query seeded workout_kind: %v", err)
	}

	// Inserting a kind_assignment with a valid FK reference should succeed.
	assignmentID, err := db.InsertKindAssignment(ctx, KindAssignment{
		ActivityID:       activityID,
		WorkoutKindID:    &seedKindID,
		AssignmentSource: AssignmentSourceManual,
		Status:           AssignmentStatusAssigned,
	})
	if err != nil {
		t.Fatalf("InsertKindAssignment with valid FK: %v", err)
	}
	if assignmentID == 0 {
		t.Fatal("expected non-zero assignment ID")
	}

	// Inserting a kind_assignment with a nonexistent workout_kind_id should
	// be rejected by the FK constraint, proving FK enforcement is ON.
	nonexistentKindID := int64(999999)
	_, err = db.InsertKindAssignment(ctx, KindAssignment{
		ActivityID:       activityID,
		WorkoutKindID:    &nonexistentKindID,
		AssignmentSource: AssignmentSourceManual,
		Status:           AssignmentStatusAssigned,
	})
	if err == nil {
		t.Fatal("expected FK constraint violation for nonexistent workout_kind_id, but insert succeeded")
	}
	// The error message should mention FOREIGN KEY or similar constraint issue.
	if !contains(err.Error(), "FOREIGN KEY", "constraint", "UNIQUE") {
		t.Logf("FK error message: %v", err)
		// Still pass, but log it; the exact error text varies by driver/context.
	}
}

func contains(s string, substrs ...string) bool {
	lower := strings.ToLower(s)
	for _, substr := range substrs {
		if strings.Contains(lower, strings.ToLower(substr)) {
			return true
		}
	}
	return false
}