kriss
a8d612f745
- FileBookmarkService: hold a security scope while creating the bookmark, fixing "file doesn't exist" on iCloud Drive-backed vaults (NSCocoaErrorDomain Code=4), which only surfaced on a real device since the Simulator strips entitlements needed to reproduce this. - Fix Keychain access group missing the Team ID prefix, which silently broke saving the master password so Face ID was never offered after backgrounding. - Add the autofill-credential-provider entitlement to the main app target (previously only on the extension) and declare ProvidesPasswords in the extension's Info.plist, so MyPass now registers as a selectable AutoFill Passwords provider. - CredentialMatcher: fall back to a scheme-prefixed re-parse when extracting a host, since KDBX entries commonly store bare domains (e.g. "allocine.fr") that URL(string:).host can't parse without an authority component. Fixes AutoFill suggestions being unranked/wrong for such entries.
61 lines
2.2 KiB
Swift
61 lines
2.2 KiB
Swift
import XCTest
|
|
@testable import MyPassCore
|
|
|
|
final class CredentialMatcherTests: XCTestCase {
|
|
func makeEntry(url: String) -> Entry {
|
|
Entry(title: "Test", url: url)
|
|
}
|
|
|
|
func test_exactURLMatch() {
|
|
let e = makeEntry(url: "https://github.com/login")
|
|
XCTAssertTrue(CredentialMatcher.matches(entry: e, serviceIdentifier: "https://github.com"))
|
|
}
|
|
|
|
func test_wwwStripped() {
|
|
let e = makeEntry(url: "https://www.github.com")
|
|
XCTAssertTrue(CredentialMatcher.matches(entry: e, serviceIdentifier: "https://github.com"))
|
|
}
|
|
|
|
func test_subdomainMatch() {
|
|
let e = makeEntry(url: "https://api.github.com")
|
|
XCTAssertTrue(CredentialMatcher.matches(entry: e, serviceIdentifier: "https://github.com"))
|
|
}
|
|
|
|
func test_differentDomain_noMatch() {
|
|
let e = makeEntry(url: "https://gitlab.com")
|
|
XCTAssertFalse(CredentialMatcher.matches(entry: e, serviceIdentifier: "https://github.com"))
|
|
}
|
|
|
|
func test_emptyURL_noMatch() {
|
|
let e = makeEntry(url: "")
|
|
XCTAssertFalse(CredentialMatcher.matches(entry: e, serviceIdentifier: "https://github.com"))
|
|
}
|
|
|
|
func test_bareDomainSubdomainMatch() {
|
|
let e = makeEntry(url: "allocine.fr")
|
|
XCTAssertTrue(CredentialMatcher.matches(entry: e, serviceIdentifier: "mon.allocine.fr"))
|
|
}
|
|
|
|
func test_bareDomainExactMatch() {
|
|
let e = makeEntry(url: "allocine.fr")
|
|
XCTAssertTrue(CredentialMatcher.matches(entry: e, serviceIdentifier: "allocine.fr"))
|
|
}
|
|
|
|
func test_bareDomainDifferentDomain_noMatch() {
|
|
let e = makeEntry(url: "allocine.fr")
|
|
XCTAssertFalse(CredentialMatcher.matches(entry: e, serviceIdentifier: "notallocine.fr"))
|
|
}
|
|
|
|
func test_filter_suggestedAndRest() {
|
|
let entries = [
|
|
makeEntry(url: "https://github.com"),
|
|
makeEntry(url: "https://gitlab.com"),
|
|
makeEntry(url: ""),
|
|
]
|
|
let result = CredentialMatcher.filter(entries: entries, for: ["https://github.com"])
|
|
XCTAssertEqual(result.suggested.count, 1)
|
|
XCTAssertEqual(result.suggested[0].url, "https://github.com")
|
|
XCTAssertEqual(result.all.count, 2)
|
|
}
|
|
}
|