Christophe Vila
0ff6793854
Lets an external reader (sqlite3 CLI, DB Browser, DataGrip) inspect the database file concurrently without "database is locked" errors while geniusrund is running. Doesn't change in-process concurrency -- queries are already fully serialized via SetMaxOpenConns(1). auth: fix flaky tampered-cookie tests Both tests corrupted a signed cookie by blindly overwriting its last character with "x", which is occasionally a no-op if that character (part of the token's signature, so effectively randomized by the embedded timestamp) already happened to be "x" -- silently passing without having tampered with anything. Confirmed via 15 repeated runs (3 spurious passes) before the fix and 30 clean runs after. flipLastChar now guarantees the byte actually changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
100 lines
2.9 KiB
Go
100 lines
2.9 KiB
Go
package auth
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
const testSecret = "test-secret-at-least-32-bytes-long!"
|
|
|
|
func TestMintAndParseSessionCookie(t *testing.T) {
|
|
claims := Claims{Sub: "u1", Name: "Alice", Email: "alice@example.com"}
|
|
cookie, err := MintSessionCookie(claims, []byte(testSecret), time.Hour, true)
|
|
if err != nil {
|
|
t.Fatalf("mint: %v", err)
|
|
}
|
|
if cookie.Name != SessionCookieName || !cookie.HttpOnly || !cookie.Secure {
|
|
t.Fatalf("cookie = %+v, want name=%s HttpOnly+Secure", cookie, SessionCookieName)
|
|
}
|
|
|
|
got, err := ParseSessionCookie(cookie, []byte(testSecret))
|
|
if err != nil {
|
|
t.Fatalf("parse: %v", err)
|
|
}
|
|
if got != claims {
|
|
t.Fatalf("got %+v, want %+v", got, claims)
|
|
}
|
|
}
|
|
|
|
func TestParseSessionCookie_Expired(t *testing.T) {
|
|
cookie, err := MintSessionCookie(Claims{Sub: "u1"}, []byte(testSecret), -time.Hour, false)
|
|
if err != nil {
|
|
t.Fatalf("mint: %v", err)
|
|
}
|
|
if _, err := ParseSessionCookie(cookie, []byte(testSecret)); err == nil {
|
|
t.Fatal("expected error for expired cookie")
|
|
}
|
|
}
|
|
|
|
func TestParseSessionCookie_Tampered(t *testing.T) {
|
|
cookie, err := MintSessionCookie(Claims{Sub: "u1"}, []byte(testSecret), time.Hour, false)
|
|
if err != nil {
|
|
t.Fatalf("mint: %v", err)
|
|
}
|
|
cookie.Value = flipLastChar(cookie.Value)
|
|
if _, err := ParseSessionCookie(cookie, []byte(testSecret)); err == nil {
|
|
t.Fatal("expected error for tampered cookie")
|
|
}
|
|
}
|
|
|
|
// flipLastChar corrupts a signed token for tamper tests, guaranteeing the
|
|
// last character actually changes -- blindly overwriting it with a fixed
|
|
// character (e.g. "x") would occasionally be a no-op if that character
|
|
// already happened to be there (it's derived from the token's embedded
|
|
// timestamp, so this isn't as rare as it sounds), silently passing the
|
|
// test without having tampered with anything.
|
|
func flipLastChar(s string) string {
|
|
last := s[len(s)-1]
|
|
replacement := byte('x')
|
|
if last == replacement {
|
|
replacement = 'y'
|
|
}
|
|
return s[:len(s)-1] + string(replacement)
|
|
}
|
|
|
|
func TestParseSessionCookie_WrongSecret(t *testing.T) {
|
|
cookie, err := MintSessionCookie(Claims{Sub: "u1"}, []byte(testSecret), time.Hour, false)
|
|
if err != nil {
|
|
t.Fatalf("mint: %v", err)
|
|
}
|
|
if _, err := ParseSessionCookie(cookie, []byte("a-completely-different-secret!!")); err == nil {
|
|
t.Fatal("expected error for wrong secret")
|
|
}
|
|
}
|
|
|
|
func TestMintAndParseTxnCookie(t *testing.T) {
|
|
txn := TxnState{State: "abc123", CodeVerifier: "verifier-xyz"}
|
|
cookie, err := MintTxnCookie(txn, []byte(testSecret), false)
|
|
if err != nil {
|
|
t.Fatalf("mint: %v", err)
|
|
}
|
|
if cookie.Name != TxnCookieName {
|
|
t.Fatalf("cookie name = %q, want %q", cookie.Name, TxnCookieName)
|
|
}
|
|
|
|
got, err := ParseTxnCookie(cookie, []byte(testSecret))
|
|
if err != nil {
|
|
t.Fatalf("parse: %v", err)
|
|
}
|
|
if got != txn {
|
|
t.Fatalf("got %+v, want %+v", got, txn)
|
|
}
|
|
}
|
|
|
|
func TestClearCookie(t *testing.T) {
|
|
c := ClearCookie(SessionCookieName, true)
|
|
if c.Value != "" || c.MaxAge >= 0 {
|
|
t.Fatalf("ClearCookie = %+v, want empty value and negative MaxAge", c)
|
|
}
|
|
}
|